Von: sarah@lemon.ircnow.org
Betreff: NGIRCD bug report
Datum: 28. April 2021 um 14:30:08 MESZ
An: alex@barton.de
X-Spam-Status: No, score=-2.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
X-Greylist: delayed 399 seconds by postgrey-1.36 at arthur; Wed, 28 Apr 2021 14:36:50 CEST
User-Agent: SquirrelMail/1.4.22

Hello,

I am writing to you to report a bug in ngircd.
In any give channel, if an user is with mode +a (admin), he/she can sets
mode +/-q(owner) to any other user. This is not inline with the
documentation.

I've looked into the code irc-mode.c, apparently an if block is missing.
Below are the code snippets that I believe fixes the bug.

BR,
sarah

               /* --- Channel user modes --- */
               case 'q': /* Owner */
                       if(!is_oper && !is_machine && !is_owner) {
                               connected = IRC_WriteErrClient(Origin,
                                       ERR_CHANOPPRIVTOOLOW_MSG,
                                       Client_ID(Origin),
                                       Channel_Name(Channel));
                               goto chan_exit;
                       }
               case 'a': /* Channel admin */